Implement migration to ComponentProvider pattern for environment-base… #1681 #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d factories - Introduced new factories: `ComponentProviderBasedSpanProcessorFactory`, `ComponentProviderBasedSamplerFactory`, `ComponentProviderBasedExporterFactory`, and `ComponentProviderBasedLogRecordProcessorFactory` to replace legacy factory interfaces. - Updated `TracerProviderFactory` to utilize the new ComponentProvider-based factories. - Added `MIGRATION_SUMMARY.md` detailing the migration process, benefits, and testing outcomes. - Ensured backward compatibility and maintained existing environment variable configurations.
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
|
|
Hey @31oli31 👋 I think a lot of this might already have been implemented in https://github.com/open-telemetry/opentelemetry-php/tree/2.x Potentially worth double checking there first to see if there are any unidentified areas that need coverage. |
Comment on lines
+10
to
+11
| use OpenTelemetry\Config\SDK\ComponentProvider\Logs\LogRecordProcessorBatch; | ||
| use OpenTelemetry\Config\SDK\ComponentProvider\Logs\LogRecordProcessorSimple; |
There was a problem hiding this comment.
These are an optional dependency and not currently included in the SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d factories
ComponentProviderBasedSpanProcessorFactory,ComponentProviderBasedSamplerFactory,ComponentProviderBasedExporterFactory, andComponentProviderBasedLogRecordProcessorFactoryto replace legacy factory interfaces.TracerProviderFactoryto utilize the new ComponentProvider-based factories.MIGRATION_SUMMARY.mddetailing the migration process, benefits, and testing outcomes.Should solve issue #1681